Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New teacher skills page #4499

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

New teacher skills page #4499

wants to merge 11 commits into from

Conversation

emmaachesongray
Copy link
Contributor

@emmaachesongray emmaachesongray commented Jan 21, 2025

Trello card

https://trello.com/c/yQOslE1u/7123

Context

We need to create a new page on the GIT website that focuses on skills needed to teach, to make the most of opportunities to capture traffic from the SERPs.

Changes proposed in this pull request

Create new skills page.

Guidance to review

@github-actions github-actions bot added ruby Pull requests that update Ruby code content Content changes labels Jan 21, 2025
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @emmaachesongray - some minor comments for you!

Copy link
Collaborator

@Sarah-DfE Sarah-DfE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds really good @emmaachesongray just made a few comments

Co-authored-by: Sarah-DfE <[email protected]>
Co-authored-by: Gemma Dallman <[email protected]>
<%= render Categories::CardComponent.new(heading_tag: "h2", card:
OpenStruct.new(
title: "Skills needed to be a teacher",
description: "Find out about the the skills needed for teaching, including subject knowledge, pedagogy, and soft skills.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is pedagogy a skill - not sure that quite makes sense?

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes Review ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants