-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New teacher skills page #4499
base: master
Are you sure you want to change the base?
New teacher skills page #4499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @emmaachesongray - some minor comments for you!
app/views/content/life-as-a-teacher/teaching-as-a-career/_categories.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/teaching-as-a-career/skills-to-teach/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/teaching-as-a-career/skills-to-teach/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/teaching-as-a-career/skills-to-teach/_article.html.erb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds really good @emmaachesongray just made a few comments
...iews/content/life-as-a-teacher/change-careers/benefits-of-changing-careers/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/teaching-as-a-career/skills-to-teach/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/teaching-as-a-career/skills-to-teach/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/teaching-as-a-career/skills-to-teach/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/teaching-as-a-career/skills-to-teach/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/teaching-as-a-career/skills-to-teach/_article.html.erb
Show resolved
Hide resolved
...iews/content/life-as-a-teacher/change-careers/benefits-of-changing-careers/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/teaching-as-a-career/skills-to-teach/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/teaching-as-a-career/skills-to-teach/_article.html.erb
Outdated
Show resolved
Hide resolved
Co-authored-by: Sarah-DfE <[email protected]> Co-authored-by: Gemma Dallman <[email protected]>
<%= render Categories::CardComponent.new(heading_tag: "h2", card: | ||
OpenStruct.new( | ||
title: "Skills needed to be a teacher", | ||
description: "Find out about the the skills needed for teaching, including subject knowledge, pedagogy, and soft skills.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is pedagogy a skill - not sure that quite makes sense?
app/views/content/steps-to-become-a-teacher/_step_8_start_your_career.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/teaching-as-a-career/skills-to-teach/_article.html.erb
Outdated
Show resolved
Hide resolved
app/views/content/life-as-a-teacher/teaching-as-a-career/_categories.html.erb
Outdated
Show resolved
Hide resolved
Review app deployed to https://get-into-teaching-app-review-4499.test.teacherservices.cloud |
Quality Gate passedIssues Measures |
Trello card
https://trello.com/c/yQOslE1u/7123
Context
We need to create a new page on the GIT website that focuses on skills needed to teach, to make the most of opportunities to capture traffic from the SERPs.
Changes proposed in this pull request
Create new skills page.
Guidance to review