Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed paas related code #1402

Merged

Conversation

VenkataChalla554
Copy link
Contributor

@VenkataChalla554 VenkataChalla554 commented Jan 9, 2024

Trello card

https://trello.com/c/gmRLlM2q/842-code-clean-up-teacher-training-advisor

Context

Removed unused codes

Changes proposed in this pull request

Removed terraform code and ruby code.

Guidance to review

Terraform code , ruby code removed and updated reade.me

@saliceti saliceti changed the title Reomoved paas related code Removed paas related code Jan 10, 2024
bin/.gitkeep Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be kept as the bin directory is required to run terrafile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this

README.md Show resolved Hide resolved
@saliceti
Copy link
Member

Also please remove the terraform/.gitignore file and replace with .gitignore at the root like: https://github.com/DFE-Digital/cpd-information/blob/main/.gitignore

@VenkataChalla554 VenkataChalla554 force-pushed the 842-code-clean-up-teacher-training-advisor-1 branch from 6077657 to 52e16bc Compare January 10, 2024 10:57
@VenkataChalla554 VenkataChalla554 merged commit 80502c1 into master Jan 10, 2024
2 of 3 checks passed
@VenkataChalla554 VenkataChalla554 deleted the 842-code-clean-up-teacher-training-advisor-1 branch January 10, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants