Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

Merge pull request #10 from DFE-Digital/add-sonarcloud #7

Merge pull request #10 from DFE-Digital/add-sonarcloud

Merge pull request #10 from DFE-Digital/add-sonarcloud #7

Triggered via push April 8, 2024 14:27
Status Failure
Total duration 1m 29s
Artifacts
Fit to window
Zoom out
Zoom in

Annotations

1 error and 10 warnings
build-and-test
Process completed with exit code 1.
build-and-test: Dfe.Identifiers.Domain/Query/EstablishmentQueryResult.cs#L7
Non-nullable field 'Establishment' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
build-and-test: Dfe.Identifiers.Domain/Query/EstablishmentQueryResult.cs#L8
Non-nullable field 'LocalAuthority' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
build-and-test: Dfe.Identifiers.Domain/Helpers/IdentifierMapping.cs#L11
Dereference of a possibly null reference.
build-and-test: Dfe.Identifiers.Domain/Query/EstablishmentQueryResult.cs#L7
Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104)
build-and-test: Dfe.Identifiers.Domain/Query/EstablishmentQueryResult.cs#L9
Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104)
build-and-test: Dfe.Identifiers.Domain/Query/EstablishmentQueryResult.cs#L8
Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104)
build-and-test: Dfe.Identifiers.Infrastructure/Repositories/EstablishmentRepository.cs#L17
Possible null reference argument for parameter 'value' in 'bool string.StartsWith(string value)'.
build-and-test: Dfe.Identifiers.Infrastructure/Repositories/EstablishmentRepository.cs#L17
Possible null reference argument for parameter 'value' in 'bool string.EndsWith(string value)'.
build-and-test: Dfe.Identifiers.Infrastructure/Migrations/20240328120816_Initial.cs#L25
Define a constant instead of using this literal 'SqlServer:Identity' 6 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
build-and-test: Dfe.Identifiers.Infrastructure/Migrations/20240328120816_Initial.cs#L35
Define a constant instead of using this literal 'Ref_EducationEstablishmentType' 4 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)