Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

Update dependency xunit to 2.9.2 #131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dfe.Identifiers.Api.Test/Dfe.Identifiers.Api.Test.csproj
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="8.0.8" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1"/>
<PackageReference Include="Moq" Version="4.20.72" />
<PackageReference Include="xunit" Version="2.9.0"/>
<PackageReference Include="xunit" Version="2.9.2"/>
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>

Unchanged files with check annotations Beta

public record EstablishmentQueryResult
{
public Establishment Establishment;

Check warning on line 7 in Dfe.Identifiers.Domain/Query/EstablishmentQueryResult.cs

GitHub Actions / build-and-test

Non-nullable field 'Establishment' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.

Check warning on line 7 in Dfe.Identifiers.Domain/Query/EstablishmentQueryResult.cs

GitHub Actions / build-and-test

Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104)
public LocalAuthority LocalAuthority;

Check warning on line 8 in Dfe.Identifiers.Domain/Query/EstablishmentQueryResult.cs

GitHub Actions / build-and-test

Non-nullable field 'LocalAuthority' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.

Check warning on line 8 in Dfe.Identifiers.Domain/Query/EstablishmentQueryResult.cs

GitHub Actions / build-and-test

Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104)
public EstablishmentType? EstablishmentType;

Check warning on line 9 in Dfe.Identifiers.Domain/Query/EstablishmentQueryResult.cs

GitHub Actions / build-and-test

Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104)
};
public static EstablishmentIdentifiers MapEstablishmentToIdentifiers(Establishment establishment)
{
return new EstablishmentIdentifiers(UKPRN: establishment.UKPRN, URN: establishment.URN.ToString(),
LAESTAB: $"{establishment.LocalAuthority.Code}/{establishment.EstablishmentNumber}");

Check warning on line 11 in Dfe.Identifiers.Domain/Helpers/IdentifierMapping.cs

GitHub Actions / build-and-test

Dereference of a possibly null reference.
}
public static TrustIdentifiers MapTrustToIdentifiers(Trust trust)
{
var establishments = await BaseQuery().Where(establishment =>
establishment.Establishment.UKPRN == identifier || establishment.Establishment.URN.ToString() == identifier ||
identifier.StartsWith(establishment.LocalAuthority.Code) && identifier.EndsWith(establishment.Establishment.EstablishmentNumber.ToString())

Check warning on line 17 in Dfe.Identifiers.Infrastructure/Repositories/EstablishmentRepository.cs

GitHub Actions / build-and-test

Possible null reference argument for parameter 'value' in 'bool string.StartsWith(string value)'.

Check warning on line 17 in Dfe.Identifiers.Infrastructure/Repositories/EstablishmentRepository.cs

GitHub Actions / build-and-test

Possible null reference argument for parameter 'value' in 'bool string.EndsWith(string value)'.
)
.ToListAsync(cancellationToken);
var results = establishments.Select(ConvertQueryResultToEstablishment).ToList();
columns: table => new
{
SK = table.Column<int>(type: "int", nullable: false)
.Annotation("SqlServer:Identity", "1, 1"),

Check warning on line 25 in Dfe.Identifiers.Infrastructure/Migrations/20240328120816_Initial.cs

GitHub Actions / build-and-test

Define a constant instead of using this literal 'SqlServer:Identity' 6 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
FK_Trust = table.Column<int>(type: "int", nullable: false),
FK_EducationEstablishment = table.Column<int>(type: "int", nullable: false)
},
protected override void Up(MigrationBuilder migrationBuilder)
{
migrationBuilder.EnsureSchema(
name: "academisation");

Check warning on line 14 in Dfe.Identifiers.Infrastructure/Migrations/Academisation/20240423142452_InitialCreate.cs

GitHub Actions / build-and-test

Define a constant instead of using this literal 'academisation' 9 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
migrationBuilder.CreateTable(
name: "FormAMatProject",