Make test more comprehensive

DFE-Digital · Jun 21, 2024 · e900934 · e900934
1 parent 50574bf
commit e900934
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/spec/wizards/placements/add_placement/steps/additional_subjects_spec.rb b/spec/wizards/placements/add_placement/steps/additional_subjects_spec.rb
@@ -14,14 +14,16 @@
       let(:parent_subject) { create(:subject) }
 
       it "is invalid if the additional subject does not exist" do
-        step = described_class.new(school:, parent_subject_id: parent_subject.id, additional_subject_ids: %w[not_a_subject])
+        child_subject = create(:subject, parent_subject:)
+        step = described_class.new(school:, parent_subject_id: parent_subject.id, additional_subject_ids: ["not_a_subject", child_subject.id])
 
         expect(step).to be_invalid
       end
 
       it "is valid if all additional subjects exist and are children of the parent subject" do
         child_subject = create(:subject, parent_subject:)
-        step = described_class.new(school:, parent_subject_id: parent_subject.id, additional_subject_ids: [child_subject.id])
+        child_subject_2 = create(:subject, parent_subject:)
+        step = described_class.new(school:, parent_subject_id: parent_subject.id, additional_subject_ids: [child_subject.id, child_subject_2.id])
 
         expect(step).to be_valid
       end