Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all claim statuses and handle their display #1193

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Add all claim statuses and handle their display #1193

merged 1 commit into from
Nov 21, 2024

Conversation

Nitemaeric
Copy link
Contributor

Context

We have a definitive list of claim statuses:

CleanShot 2024-11-20 at 21 24 31@2x

We can add all the status values to the claim_status enum in preparation for the operational flows.

Changes proposed in this pull request

  • Add claim statuses to claim_status db enum.
  • Add claim statuses to Claims::Claim status enum.
  • Handle claim statuses presentations within the Claim::StatusTagComponent.

Guidance to review

Screenshots

CleanShot 2024-11-20 at 21 45 38@2x

@Nitemaeric Nitemaeric added the deploy A Review App will be created for PRs with this label label Nov 20, 2024
@Nitemaeric Nitemaeric self-assigned this Nov 20, 2024
@Nitemaeric Nitemaeric requested review from a team as code owners November 20, 2024 21:46
@Nitemaeric Nitemaeric force-pushed the dd/add-all-claim-statuses branch from 8a40d49 to 168ce34 Compare November 20, 2024 21:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

Review app track and pay deployed to https://track-and-pay-1193.test.teacherservices.cloud was deleted
Review app school placements deployed to https://manage-school-placements-1193.test.teacherservices.cloud was deleted

@Nitemaeric Nitemaeric force-pushed the dd/add-all-claim-statuses branch from 168ce34 to c3253db Compare November 20, 2024 23:00
ollietreend
ollietreend approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@ollietreend ollietreend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many colours! 🌈

A cat with rainbow coming out of its hands

@Nitemaeric Nitemaeric merged commit c1817db into main Nov 21, 2024
8 checks passed
@Nitemaeric Nitemaeric deleted the dd/add-all-claim-statuses branch November 21, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ollietreend ollietreend ollietreend approved these changes

Assignees

@Nitemaeric Nitemaeric

Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nitemaeric @ollietreend