Add error details to internal server error page when local #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitemaeric
force-pushed
the
dd/add-error-details-to-internal-server-error-when-local
branch
2 times, most recently
from
ddc014b to
ec4b755
Compare
ollietreend
approved these changes
Nov 21, 2024
| @@ -18,4 +18,18 @@ | |||
| </p> | |||
| </div> | |||
| </div> | |||
|
|
|||
| <% if Rails.env.development? %> | |||
There was a problem hiding this comment.
Just to note that you may have some trouble getting past RSpec + Undercover with your changes to the controller action.
You might have more success leaving the controller untouched and doing this in the view:
Suggested change
| <% if Rails.env.development? %> | |
| <% if Rails.env.development? && exception = request.env["action_dispatch.exception"]&.cause %> |
Nitemaeric
force-pushed
the
dd/add-error-details-to-internal-server-error-when-local
branch
from
ec4b755 to
27e32c1
Compare
Nitemaeric
force-pushed
the
dd/add-error-details-to-internal-server-error-when-local
branch
from
27e32c1 to
b3270b8
Compare
Nitemaeric
deleted the
dd/add-error-details-to-internal-server-error-when-local
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
It's slightly inconvenient to switch to the server logs to see what is causing an internal server error on our local machines - namely when translations are missing.
I want to be told what the error is so I can immediately address it.
Changes proposed in this pull request
development.Guidance to review
Screenshots