Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove email_address from provider model #1313

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Remove email_address from provider model #1313

merged 1 commit into from
Jan 16, 2025

Conversation

JamieCleare2525
Copy link
Contributor

Context

  • Remove email_address from Provider model
  • Replace calls to email_address from provider with primary_email_address and email_addresses methods.

Changes proposed in this pull request

  • Migration to remove email_address from Provider` table
  • Migrations to set all existing provider email addresses as primary: true
  • Changes to code to use primary_email_address and email_addresses.

Link to Trello card

https://trello.com/c/FbmyXt7z/345-allow-providers-to-have-multiple-email-addresses

Screenshots

screencapture-placements-localhost-3000-providers-000a5f51-da02-4057-900b-9e91ef478465-2025-01-16-13_16_06

@JamieCleare2525 JamieCleare2525 added the deploy A Review App will be created for PRs with this label label Jan 16, 2025
@JamieCleare2525 JamieCleare2525 self-assigned this Jan 16, 2025
@JamieCleare2525 JamieCleare2525 requested review from a team as code owners January 16, 2025 13:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

Review app track and pay deployed to https://track-and-pay-1313.test.teacherservices.cloud was deleted
Review app school placements deployed to https://manage-school-placements-1313.test.teacherservices.cloud was deleted

@JamieCleare2525 JamieCleare2525 merged commit afe172d into main Jan 16, 2025
12 checks passed
@JamieCleare2525 JamieCleare2525 deleted the jc/remove_email_address_from_provider_model branch January 16, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kizr Kizr Kizr approved these changes

Assignees

@JamieCleare2525 JamieCleare2525

Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamieCleare2525 @Kizr