Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve validation for clawback payer response upload #1353

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Improve validation for clawback payer response upload #1353

merged 2 commits into from
Jan 30, 2025

Conversation

JamieCleare2525
Copy link
Contributor

@JamieCleare2525 JamieCleare2525 commented Jan 30, 2025 •
edited
Loading

Context

  • Improve validation for the Clawback - Upload Payer Response Wizard

Changes proposed in this pull request

  • Changes to Claims::UploadESFAClawbackResponseWizard and related steps to validate rows, headers and inputs of the uploaded CSV.

Guidance to review

  • Sign in as Colin (Support user)
  • Navigate to Claims -> Clawbacks
  • (assuming you have claims in the clawback_in_progress status)
  • Click "Upload payer response`
  • Upload a CSV with valid headers and inputs
  • You should see the CSV shown on the confirmation page
  • Click "Confirm upload"
  • You should see a success message
  • Try this again, but this time change the headers and inputs of your CSV
  • You should see validation errors

Link to Trello card

https://trello.com/c/OzcdNrYU/379-csv-uploads-upload-payer-responses

Screenshots

screencapture-claims-localhost-3000-support-claims-clawbacks-claims-upload-esfa-response-new-70fdee77-d8ba-4d93-a0fc-69ab4eb3ea41-upload-2025-01-30-11_09_56

screencapture-claims-localhost-3000-support-claims-clawbacks-claims-upload-esfa-response-new-70fdee77-d8ba-4d93-a0fc-69ab4eb3ea41-confirmation-2025-01-30-11_10_38

screencapture-claims-localhost-3000-support-claims-clawbacks-claims-2025-01-30-11_10_54

@JamieCleare2525 JamieCleare2525 added the deploy A Review App will be created for PRs with this label label Jan 30, 2025
@JamieCleare2525 JamieCleare2525 self-assigned this Jan 30, 2025
@JamieCleare2525 JamieCleare2525 requested review from a team as code owners January 30, 2025 11:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2025 •
edited
Loading

Review app track and pay deployed to https://track-and-pay-1353.test.teacherservices.cloud was deleted
Review app school placements deployed to https://manage-school-placements-1353.test.teacherservices.cloud was deleted

@JamieCleare2525 JamieCleare2525 merged commit 70a6203 into main Jan 30, 2025
10 checks passed
@JamieCleare2525 JamieCleare2525 deleted the jc/improve_clawback_payer_response_validation branch January 30, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dp-daly dp-daly dp-daly approved these changes

Assignees

@JamieCleare2525 JamieCleare2525

Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamieCleare2525 @dp-daly