Move find placements to top level #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kizr
force-pushed
the
ba/move_find_placements_to_top_level
branch
from
da81fad to
2d00c0c
Compare
JamieCleare2525
approved these changes
May 20, 2024
https://trello.com/c/hEGTjNTy Takes all of the controllers, views, specs and translations and moves them up a level in the file structure. Also includes the relevant changes for routes and paths to keep things running.
Kizr
force-pushed
the
ba/move_find_placements_to_top_level
branch
from
6c77889 to
559ba18
Compare
ollietreend
added
the
deploy
|
Review app track and pay deployed to https://track-and-pay-639.test.teacherservices.cloud was deleted |
CatalinVoineag
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We will need to add a "My placements" page in the future that should live at the existing "Find placements" page, this refactors "Find placements" in preparation for the "My placements" work.
Changes proposed in this pull request
Guidance to review
Sign in as Patricia and verify that everything continues to work as expecetd. The only visible change is that the new URL will just be
/placementsLink to Trello card
Move placements search results to the top-level namespace