Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompose add subject #787

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Decompose add subject #787

merged 5 commits into from
Jun 21, 2024

Conversation

Kizr
Copy link
Contributor

@Kizr Kizr commented Jun 20, 2024

Context

The wizard is becoming unmanageable and unmaintainable it, we need to begin refactoring the logic to fix these issues before further development is needed.

Changes proposed in this pull request

  • Add subject step
  • Use the step rather than the placement for adding subject
  • Remove redundant logic

Guidance to review

  • Log in as Anne
  • Add a placement
  • Select a subject
  • Check that it matches in check your answers
  • There should be no discernable changes to the journey

Link to Trello card

Decompose the Placements Build model into Wizard Steps

@Kizr Kizr self-assigned this Jun 20, 2024
@Kizr Kizr changed the base branch from main to ba/decompose_add_phase June 20, 2024 15:56
@Kizr Kizr changed the title Ba/decompose add phase fixed Decompose add phase Jun 20, 2024
@Kizr Kizr marked this pull request as ready for review June 20, 2024 15:57
@Kizr Kizr requested review from a team as code owners June 20, 2024 15:57
@Kizr Kizr changed the title Decompose add phase Decompose add subject Jun 20, 2024
Base automatically changed from ba/decompose_add_phase to main June 21, 2024 12:00
@Kizr Kizr force-pushed the ba/decompose_add_phase_fixed branch from 571acdf to 2749278 Compare June 21, 2024 12:01
@Kizr Kizr merged commit c349034 into main Jun 21, 2024
8 checks passed
@Kizr Kizr deleted the ba/decompose_add_phase_fixed branch June 21, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants