Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompose additional subjects #788

Merged
merged 7 commits into from
Jun 21, 2024
Merged

Conversation

Kizr
Copy link
Contributor

@Kizr Kizr commented Jun 20, 2024

Context

The wizard is becoming unmanageable and unmaintainable it, we need to begin refactoring the logic to fix these issues before further development is needed.

Changes proposed in this pull request

  • Add additional subjects step
  • Use the step rather than the placement for adding additional subjects
  • Remove redundant logic

Guidance to review

  • Log into a school that is not secondary or primary
  • Add a secondary placement
  • Select Modern foreign languages from subject
  • Select additional languages
  • Check that it matches in check your answers
  • There should be no discernable changes to the journey

Link to Trello card

Decompose the Placements Build model into Wizard Steps

@Kizr Kizr self-assigned this Jun 20, 2024
@Kizr Kizr requested review from a team as code owners June 20, 2024 16:02
@Kizr Kizr force-pushed the ba/decompose_add_phase_fixed branch from 571acdf to 2749278 Compare June 21, 2024 12:01
Base automatically changed from ba/decompose_add_phase_fixed to main June 21, 2024 12:16
@Kizr Kizr force-pushed the ba/decompose_additional_subjects_fixed branch from 9aa832c to 50574bf Compare June 21, 2024 12:48
@Kizr Kizr enabled auto-merge (rebase) June 21, 2024 13:10
@Kizr Kizr merged commit 0dace67 into main Jun 21, 2024
8 checks passed
@Kizr Kizr deleted the ba/decompose_additional_subjects_fixed branch June 21, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants