change not_ran scope. add missing tests

app/controllers/npq_separation/admin/bulk_operations/reject_applications_controller.rb

@@ -5,7 +5,7 @@ class RejectApplicationsController < NpqSeparation::AdminController
 
     def create
       if (file = params.dig(:bulk_operation_reject_applications, :file))
-        BulkOperation::RejectApplications.not_ran.destroy_all
+        BulkOperation::RejectApplications.not_started.destroy_all
         @bulk_operation.file.attach(file)
         if @bulk_operation.valid?
           @bulk_operation.save!

app/controllers/npq_separation/admin/bulk_operations/revert_applications_to_pending_controller.rb

@@ -5,7 +5,7 @@ class RevertApplicationsToPendingController < NpqSeparation::AdminController
 
     def create
       if (file = params.dig(:bulk_operation_revert_applications_to_pending, :file))
-        BulkOperation::RevertApplicationsToPending.not_ran.destroy_all
+        BulkOperation::RevertApplicationsToPending.not_started.destroy_all
         @bulk_operation.file.attach(file)
         if @bulk_operation.valid?
           @bulk_operation.save!

app/models/bulk_operation.rb

@@ -4,7 +4,7 @@ class BulkOperation < ApplicationRecord
 
   validate :file_valid
 
-  scope :not_ran, -> { where(result: nil) }
+  scope :not_started, -> { where(started_at: nil) }
 
   def started?
     started_at.present?

spec/factories/bulk_operation/reject_applications.rb

@@ -1,5 +1,5 @@
 FactoryBot.define do
-  factory :reject_applications, class: BulkOperation::RejectApplications do
+  factory :reject_applications_bulk_operation, class: BulkOperation::RejectApplications do
     admin { create(:admin) }
   end
 end

spec/jobs/bulk_operation/bulk_change_applications_to_pending_job_spec.rb

@@ -13,7 +13,7 @@
       end
     end
     let(:uploaded_file) { Rack::Test::UploadedFile.new(file.path) }
-    let(:application_ecf_ids) { [SecureRandom.uuid] }
+    let(:application_ecf_ids) { [SecureRandom.uuid, SecureRandom.uuid] }
 
     it "calls BulkOperation::BulkChangeApplicationsToPending" do
       expect(BulkOperation::BulkChangeApplicationsToPending).to receive(:new).with(application_ecf_ids:).and_call_original

spec/jobs/bulk_operation/bulk_reject_applications_job_spec.rb

@@ -4,7 +4,7 @@
   describe "#perform" do
     subject { described_class.new.perform(bulk_operation_id:) }
 
-    let(:bulk_operation) { create(:reject_applications, admin: create(:admin), file: uploaded_file) }
+    let(:bulk_operation) { create(:reject_applications_bulk_operation, admin: create(:admin), file: uploaded_file) }
     let(:bulk_operation_id) { bulk_operation.id }
     let(:file) do
       Tempfile.new.tap do |file|
@@ -13,7 +13,7 @@
       end
     end
     let(:uploaded_file) { Rack::Test::UploadedFile.new(file.path) }
-    let(:application_ecf_ids) { [SecureRandom.uuid] }
+    let(:application_ecf_ids) { [SecureRandom.uuid, SecureRandom.uuid] }
 
     it "calls BulkOperation::BulkRejectApplications" do
       expect(BulkOperation::BulkRejectApplications).to receive(:new).with(application_ecf_ids:).and_call_original

spec/models/bulk_operation_spec.rb

@@ -36,10 +36,31 @@
   end
 
   describe "scopes" do
-    context "not_ran" do
+    describe "not_started" do
+      let(:started_bulk_operation) { create(:reject_applications_bulk_operation, started_at: Time.zone.yesterday) }
+      let(:not_started_bulk_operation) { create(:reject_applications_bulk_operation, started_at: nil) }
+
+      it "returns not started bulk opeartions" do
+        expect(BulkOperation.not_started).to eq [not_started_bulk_operation]
+      end
     end
   end
 
   describe "#started?" do
+    context "when started_at present" do
+      let(:bulk_operation) { build(:reject_applications_bulk_operation, started_at: Time.zone.yesterday) }
+
+      it "returns true" do
+        expect(bulk_operation.started?).to be true
+      end
+    end
+
+    context "when started_at not present" do
+      let(:bulk_operation) { create(:reject_applications_bulk_operation, started_at: nil) }
+
+      it "returns false" do
+        expect(bulk_operation.started?).to be false
+      end
+    end
   end
 end