Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move specs out of lib into correct matching folders #2064

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alkesh
Copy link
Contributor

@alkesh alkesh commented Dec 10, 2024

Context

We have a lot of specs in the lib folder, instead of the correct matching folder for the code.

Changes proposed in this pull request

move specs in specs/lib to the correct specs/forms or specs/services folders

@alkesh alkesh requested a review from a team as a code owner December 10, 2024 09:42
Copy link
Collaborator

@cwrw cwrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we hold off on this pr, we have some big prs removing large changes from the old implementation and integration with ECF that touches most of those, as this will mess up those prs please?

Copy link

@alkesh alkesh marked this pull request as draft December 10, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants