[CPDNPQ-2346] Cohort + schedule management #2068
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://npq-registration-review-2068-web.test.teacherservices.cloud/ |
alkesh
reviewed
Dec 18, 2024
rwrrll
force-pushed
the
2346-cohort-and-schedule-admin
branch
from
21f1d96 to
967cf38
Compare
|
Thanks @alkesh – I was trying to make it obvious how the instance variables were set, but evidently just made it more confusing 😉 moved into a |
|
alkesh
approved these changes
Dec 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jebw
reviewed
Dec 20, 2024
Comment on lines
+30
to
+32
| def self.allowed_declaration_types | ||
| connection.execute("SELECT unnest(enum_range(NULL::declaration_types))").values.flatten | ||
| end |
There was a problem hiding this comment.
This seems a bit unusual or I'm not following? Whats the advantage of normalizing the list in a separate method, why not normalize it here? Though I'm also not understanding why postgres would return a blank enum type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Ticket: https://dfedigital.atlassian.net/browse/CPDNPQ-2346