Training with disabilities view on courses #4358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatalinVoineag
force-pushed
the
cv/couse-training-with-dissabilities
branch
3 times, most recently
from
035bf16 to
91f3fa1
Compare
CatalinVoineag
commented
Jul 10, 2024
| @@ -8,5 +8,4 @@ def param_form_key | |||
| end | |||
|
|
|||
| def goto_preview? = params.dig(param_form_key, :goto_preview) == 'true' | |||
| def goto_provider? = params.dig(param_form_key, :goto_provider) == 'true' | |||
There was a problem hiding this comment.
This is no longer needed after the refactor 91f3fa1
CatalinVoineag
commented
Jul 10, 2024
| @@ -14,8 +14,8 @@ def goto_provider_value(param_form_key:, params:) | |||
| params[:goto_provider] || params.dig(param_form_key, :goto_provider) | |||
| end | |||
|
|
|||
| def goto_provider?(param_form_key:, params:) | |||
There was a problem hiding this comment.
No longer needed
CatalinVoineag
changed the title
elceebee
reviewed
Jul 11, 2024
| flash[:success] = I18n.t('success.published') | ||
| redirect_to(details_publish_provider_recruitment_cycle_path(provider.provider_code, provider.recruitment_cycle_year)) | ||
| end | ||
| redirect_to @about_form.update_success_path |
There was a problem hiding this comment.
This is so much cleaner, nice one!
elceebee
reviewed
Jul 11, 2024
| ) | ||
| end | ||
| end | ||
| alias back_path update_success_path |
elceebee
reviewed
Jul 11, 2024
| <% else %> | ||
| <%= govuk_back_link_to(details_publish_provider_recruitment_cycle_path(@provider.provider_code, @provider.recruitment_cycle_year)) %> | ||
| <% end %> | ||
| <%= govuk_back_link_to(@about_form.back_path) %> |
elceebee
approved these changes
Jul 11, 2024
Content change to new view
Content changes to course page (not detailed in the original ticket)
|
CatalinVoineag
force-pushed
the
cv/couse-training-with-dissabilities
branch
from
91f3fa1 to
3aa46e4
Compare
The course show page on find and the preview page on publish contains too much information that might be off-putting for the user. This commit tries to fix this by putting this section into its own view accessible from the course page
There are a few `goto` methods that tell the about your organisation form where to redirect the user after update or when the user clicks the back links. Basically, both back links and update success methods can go to the same path based on the `goto` param. Because of this and the ever growing of these `goto` params I moved some logic that calculates the redirection in the about_your_organisation_form. This way it can be tested properly.
CatalinVoineag
force-pushed
the
cv/couse-training-with-dissabilities
branch
from
3aa46e4 to
d30f7bf
Compare
|
Looks good to me! |
kelliedesigner
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The course show page on find and the preview page on publish contains
too much information that might be off-putting for the user.
This commit tries to fix this by putting this section into its own view
accessible from the course page
Changes proposed in this pull request
347fce8 This implements the view/controller/routes changes
91f3fa1 This is a bit of a refactor of the
gotomethods that tell theabout_your_organisationform where to redirectDescription of 91f3fa1:
There are a few
gotomethods that tell the about your organisationform where to redirect the user after update or when the user clicks the
back links.
Basically, both back links and update success methods can go to the same
path based on the
gotoparam.Because of this and the ever growing of these
gotoparams I moved somelogic that calculates the redirection in the
about_your_organisation_form. This way it can be tested properly.
Guidance to review
Review the code and check if the training for disabilities page works
Checklist
Peek.2024-07-11.09-49.mp4