Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added age range to course summary in search results #4381

Merged

Conversation

dcyoung-dev
Copy link
Contributor

Context

We want to add the Age Range and Level to Course Results to highlight differences between courses

https://trello.com/c/Iwh2Yc1n

Changes proposed in this pull request

Added age range with level to Course results

Guidance to review

  • View course results

Capture-2024-07-17-144301
Capture-2024-07-17-144459

Checklist

  • Make sure all information from the Trello card is in here
  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Inform data insights team due to database changes

New method renders the appropriate text adding the level to the age range if it is a Secondary course.
Logic extracted from `Find::Courses::SummaryComponent::View#age_range_in_years_row`
The text is only rendered if its available.
The method is delegated to the `CourseDecorator`
@dcyoung-dev dcyoung-dev requested a review from a team July 17, 2024 13:46
@dcyoung-dev dcyoung-dev self-assigned this Jul 17, 2024
@dcyoung-dev dcyoung-dev changed the title Dy add age range to course summary in search results Added age range to course summary in search results Jul 17, 2024
Copy link
Contributor

@CatalinVoineag CatalinVoineag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@dcyoung-dev dcyoung-dev merged commit 10a066b into main Jul 18, 2024
36 of 38 checks passed
@dcyoung-dev dcyoung-dev deleted the dy-add-age-range-to-course-summary-in-search-results branch July 18, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants