[2061] Fix tests which will fail when rollover ends (spike) #4384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinhurry
force-pushed
the
2061-fix-tests-which-will-fail-when-rollover-ends-2
branch
3 times, most recently
from
ece728a to
18194ea
Compare
avinhurry
force-pushed
the
2061-fix-tests-which-will-fail-when-rollover-ends-2
branch
from
18194ea to
aedc4eb
Compare
These tests make more sense to fix when the time comes because: - The next recruitment cycle will become the current recruitment cycle - We should be able to remove the TDA feature flag and recruitment cycle check at this point This branch will act as a SPIKE.
avinhurry
force-pushed
the
2061-fix-tests-which-will-fail-when-rollover-ends-2
branch
from
aedc4eb to
13319f0
Compare
|
Tests are green, spike complete, closing this for now. It can be re-opened when we need it, to merge on the 1st of October 2024. |
avinhurry
deleted the
2061-fix-tests-which-will-fail-when-rollover-ends-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Following on from #4383 these will also fail when the current recruitment cycle closes.
These test mainly fail due to TDA being a 2025 cycle feature only, i.e not available in the current cycle.
These tests make more sense to fix when the time comes because:
The next recruitment cycle will become the current recruitment cycle
We should be able to remove the TDA feature flag and recruitment cycle check at this point
This branch will act as a spike and can also be re-opened when the time comes if desired.
Changes proposed in this pull request
current_recruitment_cycle_yearis updated to 2025.Guidance to review
Is everything still fully tested?
Checklist