Merge pull request #3168 from DFE-Digital/add-breadcrumbs

Add breadcrumbs to pages without them
DFE-Digital · May 13, 2024 · 10d8ab3 · 10d8ab3
2 parents 31a888a + 993c03a
commit 10d8ab3
Show file tree

Hide file tree

Showing 8 changed files with 31 additions and 7 deletions.
diff --git a/app/views/schools/availability_preferences/edit.html.erb b/app/views/schools/availability_preferences/edit.html.erb
@@ -1,4 +1,11 @@
-<%- self.page_title = "Choose how dates are displayed" %>
+<%- self.page_title = "Choose how dates are displayed"
+
+  self.breadcrumbs = {
+    @current_school.name => schools_dashboard_path,
+    'Choose how dates are displayed' => nil
+    }
+
+%>
 
 <div class="govuk-grid-row">
   <div class="govuk-grid-column-two-thirds">

diff --git a/app/views/schools/confirmed_bookings/cancellations/notification_deliveries/show.html.erb b/app/views/schools/confirmed_bookings/cancellations/notification_deliveries/show.html.erb
@@ -11,7 +11,7 @@
       What happens next
     </h2>
     <p>
-      We’ve sent your response to <%= @cancellation.candidate_name %>
+      We’ve sent your response to <%= @cancellation.candidate_name %>.
     </p>
     <p>
       We've also sent them a text message asking them to check their inbox.

diff --git a/app/views/schools/contact_us/show.html.erb b/app/views/schools/contact_us/show.html.erb
@@ -1,5 +1,4 @@
 <% self.page_title = "Contact us" %>
-
 <div class="govuk-grid-row">
   <div class="govuk-grid-column-full">
     <h1 class="govuk-heading-l">Contact us</h1>

diff --git a/app/views/schools/organisation_access_requests/show.html.erb b/app/views/schools/organisation_access_requests/show.html.erb
@@ -1,6 +1,7 @@
 <div id="dsi-org-access-request" class="govuk-grid-row">
   <div class="govuk-grid-column-full">
     <section>
+
       <%= page_heading "Request access to another organisation" %>
 
       <% if @dfe_sign_in_request_organisation_url %>

diff --git a/app/views/schools/placement_dates/close_confirmation.html.erb b/app/views/schools/placement_dates/close_confirmation.html.erb
@@ -1,8 +1,18 @@
+<% self.page_title = 'Close placement date' %>
+
+<%
+  self.breadcrumbs = {
+    @current_school.name => schools_dashboard_path,
+    'Manage dates' => schools_placement_dates_path,
+    "Close placement on #{@placement_date.date.to_formatted_s(:govuk)}" => nil
+  }
+%>
+
 <div class="govuk-main-wrapper">
   <div class="govuk-grid-row">
     <div class="govuk-grid-column-two-thirds">
       <%= form_for @confirmation, url: schools_placement_date_close_path(@placement_date.id, confirmed: :confirmed) do |f| %>
-        <%= f.govuk_radio_buttons_fieldset :confirmed, legend: { text: "Are your sure you want to close the placement on #{@placement_date.date.to_formatted_s(:govuk)}?", class: "govuk-heading-l" } do %>
+        <%= f.govuk_radio_buttons_fieldset :confirmed, legend: { text: "Are you sure you want to close the placement on #{@placement_date.date.to_formatted_s(:govuk)}?", class: "govuk-heading-l" } do %>
           <%= f.govuk_radio_button :confirmed, true, label: { text: "Yes" } %>
           <%= f.govuk_radio_button :confirmed, false, label: { text: "No" } %>
         <% end %>

diff --git a/app/views/schools/placement_requests/cancellations/notification_deliveries/show.html.erb b/app/views/schools/placement_requests/cancellations/notification_deliveries/show.html.erb
@@ -9,7 +9,7 @@
       What happens next
     </h2>
     <p>
-      We’ve sent your response to <%= @cancellation.candidate_name %>
+      We’ve sent your response to <%= @cancellation.candidate_name %>.
     </p>
 
     <%= govuk_link_to 'Return to requests', schools_placement_requests_path %>

diff --git a/app/views/schools/toggle_enabled/edit.html.erb b/app/views/schools/toggle_enabled/edit.html.erb
@@ -1,4 +1,11 @@
-<% self.page_title = "Toggle requests" %>
+<% self.page_title = "Turn profile on or off"
+
+  self.breadcrumbs = {
+    @current_school.name => schools_dashboard_path,
+    'Turn profile on or off' => nil
+  }
+
+%>
 
 <%= form_for @current_school, url: schools_enabled_path, method: 'patch' do |f| %>
   <%= f.govuk_radio_buttons_fieldset(:enabled) do %>

diff --git a/features/schools/toggle_enabling_and_disabling.feature b/features/schools/toggle_enabling_and_disabling.feature
@@ -9,7 +9,7 @@ Feature: Toggling being enabled and disabled
 
     Scenario: Page title
         Given I am on the 'toggle requests' page
-        Then the page title should be 'Toggle requests'
+        Then the page title should be 'Turn profile on or off'
 
     Scenario: Page contents
         Given I am on the 'toggle requests' page