Remove Approver users

Due to limitations on the DSI public API, we've had to re-evaluate some of bits of this work and at the moment displaying the list of users in the school or their approvers does not seem like much value. This fix addresses it by: - Removes link to school approvers from school dashboard - Removing approver users route, controller and index view - Removing `organisation_users` - Removing specs for `organisation_users`
DFE-Digital · Mar 27, 2024 · ef58c1b · ef58c1b
1 parent 97a5d6c
commit ef58c1b
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 171 deletions.
diff --git a/app/controllers/schools/approvers_controller.rb b/app/controllers/schools/approvers_controller.rb
diff --git a/app/services/schools/dfe_sign_in_api/organisation_users.rb b/app/services/schools/dfe_sign_in_api/organisation_users.rb
diff --git a/app/views/schools/approvers/index.html.erb b/app/views/schools/approvers/index.html.erb
diff --git a/app/views/schools/dashboards/_profile_and_dates.html.erb b/app/views/schools/dashboards/_profile_and_dates.html.erb
@@ -5,9 +5,6 @@
       <li>
         <%= link_to "Add new users", schools_users_path %>
       </li>
-      <li>
-        <%= link_to "View approvers at your school", schools_approvers_path %>
-      </li>
       <li>
         <%= link_to "Update school profile", schools_on_boarding_profile_path %>
       </li>

diff --git a/config/routes.rb b/config/routes.rb
@@ -65,7 +65,6 @@
 
     resource :change_school, only: %i[show create], as: 'change', path: 'change', controller: 'change_schools'
     resources :users, only: %i[index new create show], controller: 'users'
-    resources :approvers, only: %i[index], controller: 'approvers'
     resource :prepopulate_school_profiles, only: %i[create]
 
     resource :dashboard, only: :show

diff --git a/spec/services/schools/dfe_sign_in_api/organisation_users_spec.rb b/spec/services/schools/dfe_sign_in_api/organisation_users_spec.rb
-Original file line number
+Diff line change
@@ Expand Up / @@ -5,9 +5,6 @@ @@
           <li>
             <%= link_to "Add new users", schools_users_path %>
           </li>
-          <li>
-            <%= link_to "View approvers at your school", schools_approvers_path %>
-          </li>
           <li>
             <%= link_to "Update school profile", schools_on_boarding_profile_path %>
           </li>
@@ Expand Down @@