-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed domain origin_hostname to aks #2991
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temitope777
temporarily deployed
to
review_aks
October 10, 2023 12:17 — with
GitHub Actions
Inactive
saliceti
reviewed
Oct 10, 2023
terraform/domains/environment_domains/config/production.tfvars.json
Outdated
Show resolved
Hide resolved
temitope777
temporarily deployed
to
review_aks
October 10, 2023 13:21 — with
GitHub Actions
Inactive
WHY: This is so that the website could be accessed via the aks endpoint HOW: Replaced existing PAAS domain origin_hostname with the AKS one
temitope777
force-pushed
the
feature/5757-change-host-name
branch
from
October 10, 2023 13:35
239fea1
to
848fb96
Compare
saliceti
approved these changes
Oct 10, 2023
temitope777
temporarily deployed
to
review_aks
October 10, 2023 13:51 — with
GitHub Actions
Inactive
We need a minimum of 2 web replicas for high availability. The 2 workers are for sidekiq performance.
We're not sure if they are used by the app or not but this caused errors in the restore so we're enabling as well on Azure.
temitope777
temporarily deployed
to
review_aks
October 10, 2023 16:05 — with
GitHub Actions
Inactive
saliceti
force-pushed
the
feature/5757-change-host-name
branch
from
October 10, 2023 16:12
a833a18
to
c63039a
Compare
Closing in favour of #2990 |
Review app deployed to https://get-school-experience-review-pr-2991.test.teacherservices.cloud |
Review app deployed to https://review-school-experience-2991.london.cloudapps.digital |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY: This is so that the website could be accessed via the aks endpoint
HOW: Replaced existing PAAS domain origin_hostname with the AKS one
Trello card
Context
changed domain host-name to aks host
Changes proposed in this pull request
replaced existing paas with aks domain name
Guidance to review