Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for DBS certificate question on candidate flow #3103

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

MylesJarvis
Copy link
Contributor

@MylesJarvis MylesJarvis commented Mar 12, 2024

Trello card

https://trello.com/c/wUYLWrEk/389-content-dac-audit-error-handling-for-dbs-response

Context

If a candidate doesn't click an option for this question, the error message is generic, which doesn't help with accessibility. This improves the error message.

image

Changes proposed in this pull request

Select an option -> Select whether you have a DBS certificate

image

Guidance to review

  • Does this render correctly on the candidate sign up flow?

Copy link

Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@MylesJarvis MylesJarvis merged commit 934227d into master Mar 12, 2024
17 checks passed
@MylesJarvis MylesJarvis deleted the update-dbs-error branch March 12, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants