Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update accessibility statement #3104

Merged
merged 21 commits into from
Mar 21, 2024
Merged

Conversation

MylesJarvis
Copy link
Contributor

@MylesJarvis MylesJarvis commented Mar 14, 2024

Trello card

https://trello.com/c/ETvr5FLf

Context

The accessibility statement for the Get School Experience service needed updating to reflect the fact that we:

  • had a review in 2022
  • we tackled a lot of this issues back then
  • we have a couple of outstanding issues left to address

Changes proposed in this pull request

Guidance to review

  • is this now reflective of the template?

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Mar 14, 2024
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @MylesJarvis - have left a few minor comments

app/views/pages/accessibility_statement.html.erb Outdated Show resolved Hide resolved
app/views/pages/accessibility_statement.html.erb Outdated Show resolved Hide resolved
app/views/pages/accessibility_statement.html.erb Outdated Show resolved Hide resolved
app/views/pages/accessibility_statement.html.erb Outdated Show resolved Hide resolved
app/views/pages/accessibility_statement.html.erb Outdated Show resolved Hide resolved
app/views/pages/accessibility_statement.html.erb Outdated Show resolved Hide resolved
app/views/pages/accessibility_statement.html.erb Outdated Show resolved Hide resolved
@MylesJarvis MylesJarvis marked this pull request as ready for review March 20, 2024 12:11
app/views/pages/accessibility_statement.html.erb Outdated Show resolved Hide resolved
app/views/pages/accessibility_statement.html.erb Outdated Show resolved Hide resolved
app/views/pages/accessibility_statement.html.erb Outdated Show resolved Hide resolved
app/views/pages/accessibility_statement.html.erb Outdated Show resolved Hide resolved
app/views/pages/accessibility_statement.html.erb Outdated Show resolved Hide resolved
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MylesJarvis Realised that we talk about service rather than website in loads of other places - sorry, missed this before!

Let's get this out on Thursday

app/views/pages/accessibility_statement.html.erb Outdated Show resolved Hide resolved
app/views/pages/accessibility_statement.html.erb Outdated Show resolved Hide resolved
app/views/pages/accessibility_statement.html.erb Outdated Show resolved Hide resolved
app/views/pages/accessibility_statement.html.erb Outdated Show resolved Hide resolved
app/views/pages/accessibility_statement.html.erb Outdated Show resolved Hide resolved
Copy link

Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@MylesJarvis MylesJarvis merged commit 166f061 into master Mar 21, 2024
15 checks passed
@MylesJarvis MylesJarvis deleted the update-accessibility-statement branch March 21, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants