Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address review feedback on schools user invite #3105

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Address review feedback on schools user invite #3105

merged 5 commits into from
Mar 14, 2024

Conversation

ekumachidi
Copy link
Contributor

Address Feedback from this review:
#3080 (comment)

Changes proposed in this pull request

  • Update the form fields Firstname & Lastname to First name & Last name
  • On /schools/users page - DfE Sign-in link should redirect users to /approvals/users on the respective environments
  • Ensures new users are displayed On /schools/users page when a new user is invited
  • Ensure invited users receive any email notification confirming that they have been granted access to manage a school

@ekumachidi
Adds DFE Sign-in manage_users URLs across environments
8647344
@ekumachidi
Refactor users method in OrganisationUsers module
6e4b16c
@ekumachidi
Adds UserInvite Email notification
6a47091 
- Adds `NotifyEmail::SchoolUserInvite` class
- Adds its corresponding test
- Adds markdown copy of gov notify email sent to users.
@ekumachidi
Send school user invite email
28843c3
@ekumachidi ekumachidi self-assigned this Mar 14, 2024
@github-actions github-actions bot added ruby Pull requests that update Ruby code Test Config labels Mar 14, 2024
@ekumachidi ekumachidi changed the base branch from master to ce-dsi-id-only March 14, 2024 22:35
@github-actions GitHub Actions
Copy link

Review app deployed to https://get-school-experience-review-pr-3105.test.teacherservices.cloud
✅ DfE sign in route obtained: https://get-school-experience-review-pr-3.test.teacherservices.cloud

@ekumachidi ekumachidi merged commit 7c165f1 into ce-dsi-id-only Mar 14, 2024
15 checks passed
@ekumachidi ekumachidi deleted the ce-mse-user-invite-feedback branch March 14, 2024 23:32
ekumachidi added a commit that referenced this pull request Mar 15, 2024
@ekumachidi
Revert "Address review feedback on schools user invite (#3105)"
6876e6d 
This reverts commit 7c165f1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ekumachidi ekumachidi

Labels
Config Review ruby Pull requests that update Ruby code Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ekumachidi