Implement GOV.UK Frontend v5.0 on Get school experience and Manage school experience #3109
Conversation
ekumachidi
changed the title
…hool experience GDS have announced that they have released a new version of GOV.UK Frontend v5.0.0 (breaking release) We need to upgrade Get school experience / Manage school experience to GOV.UK Frontend v5.0.0 This fix: - Updates govuk-frontend package from v4.8.0 to v5.0.0 - Updates GovUK frontend assets paths - Removes IE8 specific styles from `global-styles.scss`
ekumachidi
force-pushed
the
ce-gov-uk-front-end-upgrade
branch
from
1df88cd to
9e89d4b
Compare
| Scenario: Word counting in placement objectives | ||
| Given I am on the 'Availability preference' page for my school of choice | ||
| Then the 'Enter your availability' word count should say 'You have 150 words remaining' | ||
| # @javascript |
There was a problem hiding this comment.
can these tests be fixed rather than commented out?
There was a problem hiding this comment.
They were commented out temporarily, but have been updated.
I removed the review request because it was still WIP
ekumachidi
force-pushed
the
ce-gov-uk-front-end-upgrade
branch
from
6322ddc to
cececb8
Compare
ekumachidi
force-pushed
the
ce-gov-uk-front-end-upgrade
branch
from
f371c0f to
5e56994
Compare
|
I'll add comments as and when I find something if that's ok. I believe the Service Name needs to be bolded (and a larger heading), as does the GOV.UK element: Guidance on this from the design system: https://design-system.service.gov.uk/styles/page-template/ We should also capitalise the word 'beta'. |
|
On the candidate search page, for example this search URL, we're seeing some spillover on the filter option.
These should be aligned next to the check boxes, even with long text lengths, for example this in current implementation:
|
|
In the 'withdrawn requests' page, we have an issue with contrast on the 'unviewed' request. This won't pass accessibility requirements for contrast, so needs to be fixed. We also ned to ensure it mirrors the implementation where we have capitalised first letter, lower case rest for the tag. Current prod: vs Review app:
|
|
This appears to be an existing issue (or was perhaps introduced by other version bumps), but our tables are spilling over when there is a large amount of content and the user has a small screen. We'll need to make sure these are responsive to screen size. @gemmadallmandfe thoughts on whether we need to amend the accessibility statement with this in mind? |
- from accordion sections - from `div` elements that have the `govuk-accordion__section-content`
- Update tag colours in placement_dates_helper.rb
ekumachidi
force-pushed
the
ce-gov-uk-front-end-upgrade
branch
from
ca3f863 to
5142194
Compare
- Update tag color for cancelled bookings and unviewed requests
|
@ekumachidi just pushed a small change around capitalisations on the labels, which I hadn't flagged previously. Everything else looks good to me so I'll give this a tick once it's deployed and I've given it a final once over. |
|
Review app deployed to https://get-school-experience-review-pr-3109.test.teacherservices.cloud |
There was a problem hiding this comment.
I've had a check through against the release notes LGTM 👍
Only final question is around removing the aria-labelledby in the accordion functionality. Can you let me know where you saw that @ekumachidi? It doesn't seem to have changed the code that is output, so just curious.
Thank you @MylesJarvis I got that from the release google sheets checklist |
|
Thanks @ekumachidi, I missed that one in the 5.1.0 release notes, apologies. All good to go 👍 |
Trello card
https://trello.com/c/Z0TJAkll/
Context
GDS have announced that they have released a new version of GOV.UK Frontend v5.0.0 (breaking release)
We need to upgrade Get school experience / Manage school experience to GOV.UK Frontend v5.0.0
Changes proposed in this pull request
Guidance to review