Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve page candidate sees when school cancels booking first #3146

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Improve page candidate sees when school cancels booking first #3146

merged 4 commits into from
Apr 25, 2024

Conversation

MylesJarvis
Copy link
Contributor

@MylesJarvis MylesJarvis commented Apr 18, 2024 •
edited
Loading

Trello card

Context

Trying to improve this slightly:

image

Changes proposed in this pull request

image

  • I collaborated with @MaxineCl on these changes to get to this point.

Guidance to review

  • Use this link to access a request in the correct state.

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Apr 18, 2024
@MylesJarvis MylesJarvis changed the title Update _show_booking_cancelled_by_school.html.erb Improve page candidate sees when school cancels booking first Apr 18, 2024
@MylesJarvis MylesJarvis marked this pull request as ready for review April 24, 2024 08:11
gemmadallmandfe
gemmadallmandfe approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@github-actions GitHub Actions
Copy link

Review app deployed to https://get-school-experience-review-pr-3146.test.teacherservices.cloud
✅ DfE sign in route obtained: https://get-school-experience-review-pr-8.test.teacherservices.cloud

@MylesJarvis MylesJarvis merged commit 01e43f3 into master Apr 25, 2024
15 checks passed
@MylesJarvis MylesJarvis deleted the test-improving-school-cancellation-page branch April 25, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemmadallmandfe gemmadallmandfe gemmadallmandfe approved these changes

Assignees
No one assigned
Labels
Review ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MylesJarvis @gemmadallmandfe