Improve location of our school privacy notice #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <span class="govuk-heading-s govuk-!-margin-top-4"> | ||
| <%= link_to 'Complete your school profile', | ||
| Feature.enabled?(:task_progress_on_boarding) ? schools_on_boarding_progress_path : schools_on_boarding_profile_path, | ||
| class: 'govuk-link' | ||
| %> | ||
| </span> | ||
| </p> | ||
| <p class = "govuk-body-s"> | ||
| <small> |
There was a problem hiding this comment.
Question for @GayeCord as to whether this should be in small text?
My view is probably not - on our GIT funnels, PN references are in the same font size as other body text
There was a problem hiding this comment.
Fair point - I drew inspiration from the GIT homepage, which uses the small tag, as using full size ended up looking oversized (in my view)
GIT Homepage Email Funnel
Without <small> text
|
Review app deployed to https://get-school-experience-review-pr-3156.test.teacherservices.cloud |
gemmadallmandfe
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/XYoC2LnC
Context
Changes proposed in this pull request
Before
After (NB checkbox alignment issue is already known and ticketed up to fix)
Guidance to review