Improve button groupings (first tranche) #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Splitting each change into comments to make it easier to review: Before - turn profile on/off 
After - turn profile on/off 
|
|
Before After Note: I'll do a separate PR for the duplication of 'showing the only booking' line. |
|
Before |
|
Before After |
|
Before 
After 
|
|
Before After
|
MylesJarvis
changed the title
app/views/schools/dashboards/_no_placement_dates_warning.html.erb
Outdated
Show resolved
Hide resolved
|
LGTM other than suggested content tweak |
Co-authored-by: Gemma Dallman <[email protected]>
ekumachidi
approved these changes
Apr 26, 2024
|
Review app deployed to https://get-school-experience-review-pr-3157.test.teacherservices.cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/QHKZbml7
Context
Changes proposed in this pull request (changes in comments below)
Guidance to review
Attendance page (you will need to login as a school with attendances to confirm (Holland Park) and one without (Outwood Academy Acklam)):
Toggle page on/off:
Edit profile page (use any onboarded school)
Add dates (use any school with 'fixed dates'):
Onboarding flow (use any non-onboarded school and complete their profile details)
For the moment the main focus can be grouping - I can do separate PRs for changing buttons -> links if needed. For example, the return to dashboard buttons.