-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add location field validation error to candidate school search #3159
Conversation
Thanks @ekumachidi! A few comments from my testing of this in the preview app:
Here's an example of how it appears in the Find postgraduate teacher training service: We also use this within GSE, for example on further down the registration flow: |
Context: Ensure that we surface a validation error if a user tries to search for a school experience placement with no postcode on GSE Changes proposed: * Enable validation option on the form * Updates the javascript to include an event listener that triggers the validation
d2f72dc
to
828d903
Compare
…n candidate school search
bdbe3ed
to
9e07bc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding @martyn-w for a tech review on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The autocomplete_controller.js
file is raising an error on the search results page, when you click on search again:
autocomplete_controller.js:65 Uncaught (in promise) TypeError: r.submit is not a function
at e.<anonymous> (autocomplete_controller.js:65:12)
at p (regeneratorRuntime.js:45:16)
at Generator.<anonymous> (regeneratorRuntime.js:133:17)
at Generator.next (regeneratorRuntime.js:74:21)
at s (application-24f320543daef9df5688.js:1:1558)
at a (application-24f320543daef9df5688.js:1:1761)
at application-24f320543daef9df5688.js:1:1820
at new Promise (<anonymous>)
at e.<anonymous> (application-24f320543daef9df5688.js:1:1701)
at e.<anonymous> (autocomplete_controller.js:67:4)
Also, it might be better to create the error summary in the html layer rather than in the javascript, to allow the validations to work even if javascript is not enabled
Review app deployed to https://get-school-experience-review-pr-3159.test.teacherservices.cloud |
Closing in favour of #3198 |
Trello card
https://trello.com/c/NLPhh1Wh/
Context
Ensure that we surface a validation error if a user tries to search for a school experience placement with no postcode on GSE
Changes proposed in this pull request