Feature/1747 school experience bug #3161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temitope777
force-pushed
the
feature/1747-school-experience-bug
branch
from
fe59505 to
2d0b33f
Compare
WHY: It is important for the notification to work when there is an error but it is not able to fetch the webhook HOW: By moving the fetch notification task up before the tasks that can fail
temitope777
force-pushed
the
feature/1747-school-experience-bug
branch
from
2d0b33f to
ba76c11
Compare
saliceti
approved these changes
Apr 25, 2024
|
Review app deployed to https://get-school-experience-review-pr-3161.test.teacherservices.cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/6YL4BhVD/1747-school-experience-bug
Context
there is a slack notification bug whereby the webhook is not fetched when there is a failure
Changes proposed in this pull request
the task that fetches the webhook is moved up before the failing tasks
Guidance to review
see attached simulated failures