Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find + replace GITIS -> Get Into Teaching service #3163

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Find + replace GITIS -> Get Into Teaching service #3163

merged 2 commits into from
Apr 26, 2024

Conversation

MylesJarvis
Copy link
Contributor

@MylesJarvis MylesJarvis commented Apr 25, 2024 •
edited
Loading

Trello card

https://trello.com/c/Shy150vw

Context

  • We don't use this term anymore, so changing all instances of it.

Changes proposed in this pull request

Start page
image

Matchback question

image

Check your answers page
image

Guidance to review

  • Do a school experience request, all 3 views are on those pages.

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Apr 25, 2024
@MylesJarvis MylesJarvis marked this pull request as ready for review April 26, 2024 09:23
@github-actions GitHub Actions
Copy link

Review app deployed to https://get-school-experience-review-pr-3163.test.teacherservices.cloud
✅ DfE sign in route obtained: https://get-school-experience-review-pr-13.test.teacherservices.cloud

gemmadallmandfe
gemmadallmandfe approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@MylesJarvis MylesJarvis merged commit 4a4e026 into master Apr 26, 2024
16 checks passed
@MylesJarvis MylesJarvis deleted the change-name-gitis branch April 26, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemmadallmandfe gemmadallmandfe gemmadallmandfe approved these changes

Assignees
No one assigned
Labels
Review ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MylesJarvis @gemmadallmandfe