Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breadcrumbs to pages without them #3168

Merged
merged 16 commits into from
May 13, 2024
9 changes: 8 additions & 1 deletion app/views/schools/availability_preferences/edit.html.erb
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
<%- self.page_title = "Choose how dates are displayed" %>
<%- self.page_title = "Choose how dates are displayed"

self.breadcrumbs = {
@current_school.name => schools_dashboard_path,
'Choose how dates are displayed' => nil
}

%>

<div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
What happens next
</h2>
<p>
We’ve sent your response to <%= @cancellation.candidate_name %>
We’ve sent your response to <%= @cancellation.candidate_name %>.
</p>
<p>
We've also sent them a text message asking them to check their inbox.
Expand Down
1 change: 0 additions & 1 deletion app/views/schools/contact_us/show.html.erb
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<% self.page_title = "Contact us" %>

<div class="govuk-grid-row">
<div class="govuk-grid-column-full">
<h1 class="govuk-heading-l">Contact us</h1>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<div id="dsi-org-access-request" class="govuk-grid-row">
<div class="govuk-grid-column-full">
<section>

<%= page_heading "Request access to another organisation" %>

<% if @dfe_sign_in_request_organisation_url %>
Expand Down
12 changes: 11 additions & 1 deletion app/views/schools/placement_dates/close_confirmation.html.erb
Original file line number Diff line number Diff line change
@@ -1,8 +1,18 @@
<% self.page_title = 'Close placement date' %>

<%
self.breadcrumbs = {
@current_school.name => schools_dashboard_path,
'Manage dates' => schools_placement_dates_path,
"Close placement on #{@placement_date.date.to_formatted_s(:govuk)}" => nil
}
%>

MylesJarvis marked this conversation as resolved.
Show resolved Hide resolved
<div class="govuk-main-wrapper">
<div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds">
<%= form_for @confirmation, url: schools_placement_date_close_path(@placement_date.id, confirmed: :confirmed) do |f| %>
<%= f.govuk_radio_buttons_fieldset :confirmed, legend: { text: "Are your sure you want to close the placement on #{@placement_date.date.to_formatted_s(:govuk)}?", class: "govuk-heading-l" } do %>
<%= f.govuk_radio_buttons_fieldset :confirmed, legend: { text: "Are you sure you want to close the placement on #{@placement_date.date.to_formatted_s(:govuk)}?", class: "govuk-heading-l" } do %>
<%= f.govuk_radio_button :confirmed, true, label: { text: "Yes" } %>
<%= f.govuk_radio_button :confirmed, false, label: { text: "No" } %>
<% end %>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
What happens next
</h2>
<p>
We’ve sent your response to <%= @cancellation.candidate_name %>
We’ve sent your response to <%= @cancellation.candidate_name %>.
</p>

<%= govuk_link_to 'Return to requests', schools_placement_requests_path %>
Expand Down
9 changes: 8 additions & 1 deletion app/views/schools/toggle_enabled/edit.html.erb
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
<% self.page_title = "Toggle requests" %>
<% self.page_title = "Turn profile on or off"

self.breadcrumbs = {
@current_school.name => schools_dashboard_path,
'Turn profile on or off' => nil
}

%>

<%= form_for @current_school, url: schools_enabled_path, method: 'patch' do |f| %>
<%= f.govuk_radio_buttons_fieldset(:enabled) do %>
Expand Down
2 changes: 1 addition & 1 deletion features/schools/toggle_enabling_and_disabling.feature
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Feature: Toggling being enabled and disabled

Scenario: Page title
Given I am on the 'toggle requests' page
Then the page title should be 'Toggle requests'
Then the page title should be 'Turn profile on or off'

Scenario: Page contents
Given I am on the 'toggle requests' page
Expand Down
Loading