Refactor #placement_date_subject
#3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rations::SubjectAndDateInformation.rb * Exclude hidden subjects from `placement_date_subjects` query *Refactor `#placement_date_subject` in `subject_and_date_information.rb` to use `find_placement_date_subject` method * update specs to reflect changes to the model
ekumachidi
force-pushed
the
placement-date-subject
branch
from
99df245 to
8459a1a
Compare
|
Review app deployed to https://get-school-experience-review-pr-3169.test.teacherservices.cloud |
MylesJarvis
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
#placement_date_subjectinsubject_and_date_information.rbto usefind_placement_date_subjectmethod