Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2110] Enable dfe analytics federated authentication #3296

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Oct 29, 2024

Trello card

https://trello.com/c/YUxcTtXB

Context

Enable Google cloud federated authentication to stop using secret keys

Changes proposed in this pull request

  • Add dfe_analytics terraform module
  • Enable for review apps
  • Authorise deployment workflow

Guidance to review

Check review app events are logged in staging dataset

@github-actions github-actions bot added ruby Pull requests that update Ruby code Config labels Oct 29, 2024
@saliceti saliceti force-pushed the 2110-school-experience-migrate-to-gcp-wif branch from 9502eab to aace4f3 Compare December 6, 2024 15:11
@github-actions github-actions bot added the Review label Dec 6, 2024
@saliceti saliceti force-pushed the 2110-school-experience-migrate-to-gcp-wif branch 2 times, most recently from 5ef5fc6 to 0d20132 Compare December 6, 2024 18:03
Add dfe_analytics terraform module
Enable for review apps
@saliceti saliceti force-pushed the 2110-school-experience-migrate-to-gcp-wif branch from 0d20132 to 35bcafc Compare December 6, 2024 18:05
@saliceti saliceti marked this pull request as ready for review December 6, 2024 18:11
Copy link

github-actions bot commented Dec 6, 2024

@saliceti saliceti merged commit 75967f1 into master Dec 10, 2024
16 checks passed
@saliceti saliceti deleted the 2110-school-experience-migrate-to-gcp-wif branch December 10, 2024 09:23
@saliceti
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config DevOps Review ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants