Skip to content

Release 1773
Compare
Choose a tag to compare
@github-actions github-actions released this 18 Jun 13:28
1773
b9626c4
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.

Trello card

https://trello.com/c/ADa84TYk

Context

Before accepting the cookies, we store the HTTP referer, in order to redirect the users back to the page they were at. However there are cases where the referer is not a GET path, causing 404s because there's nothing to render.

Changes proposed in this pull request

  • Set the redirect link to root path when the referer is not recognised as a GET resource

It's utilising the Rails.application.routes.recognize_path() which by default tries to recognise GET paths. If a route is found, then we assume it's safe to redirect to, otherwise the homepage is used as a fallback.

  • Remove the cookies_policy from the REFERER_BLACKLIST.

Accepting the cookies from the /cookies_policy page, will now keep the users on the same page and won't redirect them to the edit cookies page.

  • Rename the misspelled save_refererer method to save_referer.

Guidance to review

The 404 can be reproduced with the following steps:

  1. open https://schoolexperience.education.gov.uk/candidates/feedbacks/new in incognito (or clear the cookies)
  2. click Submit feedback (with empty form)
  3. click Accept cookies at the top of the page
Assets 2
Loading