Releases: DFE-Digital/schools-experience
Release 1777
Bump get_into_teaching_api_client_faraday from 4ebbe65
to 85622bd
Release 1775
Purpose
Deliver Schools Experience to PaaS, ( review , development and Staging )
- Terraform
- Github actions
Review Advise
A lot of the code is in master as it has been pushed along to work with the github actions. so try to ignore the change differences on this PR and accept all files are NEW
Release 1776
Trello card
Context
Sentry has caught Errno::ETIMEDOUT
exceptions raised by the Redis health checks, which cause error 500.
Changes proposed in this pull request
Rescue the exception and return false as the Redis status.
Release 1774
When the api is unreachable the app raises Rack Timeout exceptions which lead to 500 responses.
Trello card
Context
We want to prevent the 500 responses when the dfe api is unreachable
Changes proposed in this pull request
Taking two extra measures to handle the timeouts:
- Add the Rack::Timeout::RequestTimeoutException to faraday's retry
exceptions to give it a second chance to succeed - Rescue the Rack Timeouts and return false to prevent the 500s
Guidance to review
Release 1773
Trello card
Context
Before accepting the cookies, we store the HTTP referer, in order to redirect the users back to the page they were at. However there are cases where the referer is not a GET path, causing 404s because there's nothing to render.
Changes proposed in this pull request
- Set the redirect link to root path when the referer is not recognised as a GET resource
It's utilising the Rails.application.routes.recognize_path()
which by default tries to recognise GET paths. If a route is found, then we assume it's safe to redirect to, otherwise the homepage is used as a fallback.
- Remove the
cookies_policy
from the REFERER_BLACKLIST.
Accepting the cookies from the /cookies_policy
page, will now keep the users on the same page and won't redirect them to the edit cookies page.
- Rename the misspelled
save_refererer
method tosave_referer
.
Guidance to review
The 404 can be reproduced with the following steps:
- open https://schoolexperience.education.gov.uk/candidates/feedbacks/new in incognito (or clear the cookies)
- click
Submit feedback
(with empty form) - click
Accept cookies
at the top of the page
Release 1748
Bump sentry-rails from 4.5.0 to 4.5.1
v175115-GA: Merge pull request #1773 from DFE-Digital/cookie-redirections
Redirect non GET referers to root_path
v175115-stable: Merge pull request #1773 from DFE-Digital/cookie-redirections
Redirect non GET referers to root_path
Release 1764
Bump redis from 4.2.5 to 4.3.1
Release 1746
Bump ws from 6.2.1 to 6.2.2