feat: Hide JS dependant elements unless JS enabled #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimwashbrook
requested review from
simonjfirth,
ThomasWhittington,
Iain-Stanger and
jack-coggin
and removed request for
simonjfirth,
ThomasWhittington and
Iain-Stanger
jimwashbrook
force-pushed
the
fix/hide-js-elements-when-js-disabled
branch
from
5c55c03 to
f511d94
Compare
|
Iain-Stanger
approved these changes
Aug 28, 2024
ThomasWhittington
approved these changes
Aug 28, 2024
Merged
jimwashbrook
added a commit
that referenced
this pull request
Aug 28, 2024
* fix(print): Move Javascript to <script> element due to CSP * feat: Hide JS dependant elements unless JS enabled * chore: move class + attribute one up * tests: Add E2E tests for feedback + print button * fix: Exclude cypress tests from sonarcloud
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GDS guidelines are to not have functionality that requires JS unless there's an alternative. If there is functionality that needs JS, and there is no alternative, the practice is to hide it for non-JS users.
This PR:
govuk-visually-hiddenandaria-hiddento the Print button, and the Feedback section.govuk-visually-hiddenIt also ignores certain IDs (at the moment, just one), as the same class is also used in the Footer for the "Support Links" header; assumedly for accessibility.
NOTE: Forked from #148 - which should be merged in first.