Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2151] Github actions OIDC #341

Merged
merged 5 commits into from
Jan 9, 2025
Merged

[2151] Github actions OIDC #341

merged 5 commits into from
Jan 9, 2025

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Jan 9, 2025

Context

Stop using service principal secrets and use OIDC instead

Changes proposed in this pull request

  • Replace secrets with federated credentials in workflows
  • Replace secrets with federated credentials in kubernetes terraform
  • Add deployment smoke test
  • Refactor domains configuration to use the same environments and federated credentials
  • The federated credentials have been created in each service principal
  • Github environment variables have been created to enable the smoke test in platform-test and test

Guidance to review

Deployment workflow with OIDC in all environments: https://github.com/DFE-Digital/teacher-services-cloud/actions/runs/12689712811
The deployment smoke test runs in platform-test and test

After merging

Delete service principal secrets

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

@saliceti saliceti added the DevOps label Jan 9, 2025
@saliceti saliceti marked this pull request as ready for review January 9, 2025 14:35
Required to use the same environments as development and production to
reuse the same federated credentials
@saliceti saliceti merged commit a6aa722 into main Jan 9, 2025
3 checks passed
@saliceti saliceti deleted the oidc-smoke-test branch January 9, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants