-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ensure alert links are pointing at appropriate endpoints (#1633)
- Loading branch information
Showing
4 changed files
with
69 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 32 additions & 3 deletions
35
TeachingRecordSystem/src/TeachingRecordSystem.SupportUi/Pages/Alerts/AlertDetail.cshtml.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,56 @@ | ||
| using Microsoft.AspNetCore.Authorization; | ||
| using Microsoft.AspNetCore.Http.Features; | ||
| using Microsoft.AspNetCore.Mvc; | ||
| using Microsoft.AspNetCore.Mvc.RazorPages; | ||
| using TeachingRecordSystem.Core.DataStore.Postgres; | ||
| using TeachingRecordSystem.Core.DataStore.Postgres.Models; | ||
| using TeachingRecordSystem.SupportUi.Infrastructure.Filters; | ||
| using TeachingRecordSystem.SupportUi.Infrastructure.Security; | ||
|
|
||
| namespace TeachingRecordSystem.SupportUi.Pages.Alerts; | ||
|
|
||
| [CheckAlertExistsFilterFactory(requiredPermission: Permissions.Alerts.Read), ServiceFilter(typeof(RequireClosedAlertFilter))] | ||
| public class AlertDetailModel(IAuthorizationService authorizationService) : PageModel | ||
| public class AlertDetailModel( | ||
| IAuthorizationService authorizationService, | ||
| TrsDbContext dbContext) : PageModel | ||
| { | ||
| public Alert? Alert { get; set; } | ||
|
|
||
| public string? ChangeReason { get; set; } | ||
|
|
||
| public string? ChangeReasonDetail { get; set; } | ||
|
|
||
| public bool CanEdit { get; set; } | ||
|
|
||
| public async Task OnGet() | ||
| { | ||
| Alert = HttpContext.Features.GetRequiredFeature<CurrentAlertFeature>().Alert; | ||
| Alert = HttpContext.GetCurrentAlertFeature().Alert; | ||
| var personId = HttpContext.GetCurrentPersonFeature().PersonId; | ||
| var changeReasonInfo = await dbContext.Database | ||
| .SqlQuery<ChangeReasonInfo>( | ||
| $""" | ||
| SELECT | ||
| payload ->> 'ChangeReason' as change_reason, | ||
| payload ->> 'ChangeReasonDetail' as change_reason_detail | ||
| FROM | ||
| events | ||
| WHERE | ||
| person_id = {personId} | ||
| AND event_name = 'AlertUpdatedEvent' | ||
| AND (payload #>> Array['Alert', 'AlertId'])::uuid = {Alert.AlertId} | ||
| AND payload #>> Array['Alert', 'EndDate'] is not null | ||
| AND payload #>> Array['OldAlert', 'EndDate'] is null | ||
| ORDER BY | ||
| created DESC | ||
| """) | ||
| .FirstOrDefaultAsync(); | ||
|
|
||
| ChangeReason = changeReasonInfo?.ChangeReason; | ||
| ChangeReasonDetail = changeReasonInfo?.ChangeReasonDetail; | ||
| CanEdit = (await authorizationService.AuthorizeForAlertTypeAsync( | ||
| User, | ||
| Alert.AlertTypeId, | ||
| Permissions.Alerts.Write)) is { Succeeded: true }; | ||
| } | ||
|
|
||
| private record ChangeReasonInfo(string ChangeReason, string ChangeReasonDetail); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters