Scrape custom metrics #1445
Merged
Scrape custom metrics #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnake
force-pushed
the
1889-scrape-custom-metrics
branch
from
2301243 to
1f062f5
Compare
saliceti
approved these changes
Jul 31, 2024
johnake
force-pushed
the
1889-scrape-custom-metrics
branch
from
1f062f5 to
8027839
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Scrape the web app and worker custom metrics
https://trello.com/c/Zlih3dRZ/1889-scrape-custom-metrics
Changes proposed in this pull request
Add enable_prometheus_monitoring to ui app and worker
remove from review tfvars before merge
Guidance to review
make terraform-plan
Check metrics are being collected for the review app
Checklist