Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose JsonDocuments #1617

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Dispose JsonDocuments #1617

wants to merge 1 commit into from

Conversation

gunndabad
Copy link
Collaborator

@gunndabad gunndabad commented Oct 25, 2024 •
edited
Loading

TIL that JsonDocument is disposable (it uses pooled storage under the hood). This changes some of our types to use JsonElement and adds disposal to where we're still using JsonDocuments.

@gunndabad gunndabad force-pushed the dispose-jsondocument branch from ccf2b17 to f37d974 Compare November 1, 2024 11:18
@gunndabad gunndabad force-pushed the dispose-jsondocument branch from f37d974 to 1133814 Compare November 1, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrKevJoy MrKevJoy MrKevJoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gunndabad @MrKevJoy