Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Restore alias matching for TRN requests #1680

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −4
Open

[DO NOT MERGE] Restore alias matching for TRN requests #1680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions TeachingRecordSystem/src/TeachingRecordSystem.Api/V3/Core/Operations/CreateTrnRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,7 @@ public class CreateTrnRequestHandler(
TrnRequestHelper trnRequestHelper,
ICurrentUserProvider currentUserProvider,
ITrnGenerationApiClient trnGenerationApiClient,
#pragma warning disable CS9113 // Parameter is unread.
INameSynonymProvider nameSynonymProvider,
#pragma warning restore CS9113 // Parameter is unread.
MessageSerializer messageSerializer)
{
public async Task<TrnRequestInfo> Handle(CreateTrnRequestCommand command)
Expand All @@ -50,8 +48,7 @@ public async Task<TrnRequestInfo> Handle(CreateTrnRequestCommand command)
var firstName = firstAndMiddleNames.First();
var middleName = string.Join(' ', firstAndMiddleNames.Skip(1));

//var firstNameSynonyms = (await nameSynonymProvider.GetAllNameSynonyms()).GetValueOrDefault(firstName, []);
var firstNameSynonyms = Array.Empty<string>(); // Disabled temporarily
var firstNameSynonyms = (await nameSynonymProvider.GetAllNameSynonyms()).GetValueOrDefault(firstName, []);

var normalizedNino = NationalInsuranceNumberHelper.Normalize(command.NationalInsuranceNumber);

Expand Down
Loading