Added fixes while testing against CRM build environment data #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunndabad
reviewed
Dec 16, 2024
TeachingRecordSystem/src/TeachingRecordSystem.Core/Jobs/SyncAllInductionsFromCrmJob.cs
Outdated
Show resolved
Hide resolved
gunndabad
approved these changes
Dec 16, 2024
hortha
temporarily deployed
to
pre-production
GitHub Actions
Inactive
hortha
force-pushed
the
fix-induction-sync-job-issues
branch
from
f09c226 to
ac1b899
Compare
hortha
had a problem deploying
to
pre-production
GitHub Actions
Failure
hortha
temporarily deployed
to
pre-production
GitHub Actions
Inactive
Removed temporary code to avoid running the sync job against all data in CRM build Skip test which is failing in CI for the moment Added logging to sync helper to highlight when we're getting CRM rate limiting Added more logging when rate limiting is hit
hortha
force-pushed
the
fix-induction-sync-job-issues
branch
from
841f382 to
7f062cb
Compare
hortha
temporarily deployed
to
pre-production
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As the
SyncAllInductionsFromCrmJobwas run against more volumes of data, various issues came to light which needed fixing.Changes proposed in this pull request
Various tweaks to ensure that all induction data and related audit history for dfeta_induction and contact table get synced correctly.
Checklist