Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change induction status page #1755

Merged
merged 16 commits into from
Dec 27, 2024

PR comment - remove nullability on param

1bd9b3d
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Change induction status page #1755

PR comment - remove nullability on param
1bd9b3d
Select commit
Loading
Failed to load commit list.
GitHub Actions / TeachingRecordSystem.WebCommon.Tests test results succeeded Dec 27, 2024 in 1s

57 passed, 0 failed and 0 skipped

Tests passed successfully

✅ TeachingRecordSystem/tests/TeachingRecordSystem.WebCommon.Tests/TestResults/_fv-az695-395_2024-12-27_13_08_13.trx

57 tests were completed in 4s with 57 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
TeachingRecordSystem.WebCommon.Tests.FormFlow.EndToEndTests 5✅ 239ms
TeachingRecordSystem.WebCommon.Tests.FormFlow.JourneyInstanceIdTests 16✅ 289ms
TeachingRecordSystem.WebCommon.Tests.FormFlow.JourneyInstanceProviderTests 28✅ 661ms
TeachingRecordSystem.WebCommon.Tests.FormFlow.JourneyInstanceTests 4✅ 492ms
TeachingRecordSystem.WebCommon.Tests.FormFlow.MissingInstanceActionFilterTests 4✅ 9ms

✅ TeachingRecordSystem.WebCommon.Tests.FormFlow.EndToEndTests

✅ Complete_DoesAllowStateToBeReadSubsequently
✅ Complete_DoesNotAllowStateToBeUpdatedSubsequently
✅ Delete_ReturnsOk
✅ ReadState_ReturnsStateAndProperties
✅ UpdateState_UpdatesStateAndRedirects

✅ TeachingRecordSystem.WebCommon.Tests.FormFlow.JourneyInstanceIdTests

✅ Create_DependentKeyFoundWithoutUniqueKey_ReturnsCorrectInstance
✅ Create_DependentKeyFoundWithUniqueKey_ReturnsCorrectInstance
✅ Create_MissingKey_ThrowsInvalidOperationException
✅ Create_NoDependentKeysWithoutUniqueKey_ReturnsCorrectInstance
✅ Create_NoDependentKeysWithUniqueKey_ReturnsCorrectInstance
✅ Create_OptionalDependentKeyFound_ReturnsCorrectInstance
✅ Create_OptionalDependentKeyNotFound_ReturnsCorrectInstance
✅ Create_UniqueKeyAlreadyInKeys_ReturnsInstanceWithNewUniqueKey
✅ TryResolve_DependentKeyFoundWithoutUniqueKey_ReturnsCorrectInstance
✅ TryResolve_DependentKeyFoundWithUniqueKey_ReturnsCorrectInstance
✅ TryResolve_MissingDependentRouteDataKey_ReturnsFalse
✅ TryResolve_MissingUniqueKey_ReturnsFalse
✅ TryResolve_NoDependentKeysWithoutUniqueKey_ReturnsCorrectInstance
✅ TryResolve_NoDependentKeysWithUniqueKey_ReturnsCorrectInstance
✅ TryResolve_OptionalDependentKeyFound_ReturnsCorrectInstance
✅ TryResolve_OptionalDependentKeyNotFound_ReturnsCorrectInstance

✅ TeachingRecordSystem.WebCommon.Tests.FormFlow.JourneyInstanceProviderTests

✅ CreateInstanceAsync_ActionHasNoMetadata_ThrowsInvalidOperationException
✅ CreateInstanceAsync_CreatesInstanceInStateStore
✅ CreateInstanceAsync_InstanceAlreadyExists_ThrowsInvalidOperationException
✅ CreateInstanceAsync_StateTypeIsIncompatible_ThrowsInvalidOperationException
✅ CreateInstanceOfT_StateTypeIsIncompatible_ThrowsInvalidOperationException
✅ GetInstanceAsync_ActionHasNoMetadata_ThrowsInvalidOperationException
✅ GetInstanceAsync_InstanceDoesExist_ReturnsInstance
✅ GetInstanceAsync_InstanceDoesNotExist_ReturnsNull
✅ GetInstanceOfT_StateTypeIsIncompatible_ThrowsInvalidOperationException
✅ GetOrCreateInstanceAsync_ActionHasNoMetadata_ThrowsInvalidOperationException
✅ GetOrCreateInstanceAsync_CreateStateStateTypeIsIncompatible_ThrowsInvalidOperationException
✅ GetOrCreateInstanceAsync_InstanceDoesExist_ReturnsExistingInstance
✅ GetOrCreateInstanceAsync_InstanceDoesNotExist_CreatesInstanceInStateStore
✅ GetOrCreateInstanceFfT_RequestedStateTypeIsIncompatible_ThrowsInvalidOperationException
✅ GetOrCreateInstanceOfT_CreateStateStateTypeIsIncompatible_ThrowsInvalidOperationException
✅ IsCurrentInstance_DifferentInstanceToCurrent_ReturnsFalse
✅ IsCurrentInstance_InstanceMatches_ReturnsTrue
✅ IsCurrentInstance_NoCurrentInstance_ReturnsFalse
✅ ResolveCurrentInstanceAsync_ActionHasNoMetadata_ReturnsNull
✅ ResolveCurrentInstanceAsync_CannotExtractIdForRandomId_ReturnsNull
✅ ResolveCurrentInstanceAsync_CannotExtractIdForRouteValues_ReturnsNull
✅ ResolveCurrentInstanceAsync_InstanceDoesNotExistInStateStore_ReturnsNull
✅ ResolveCurrentInstanceAsync_InstanceExistsForRandomId_ReturnsInstance
✅ ResolveCurrentInstanceAsync_InstanceExistsForRouteValues_ReturnsInstance
✅ ResolveCurrentInstanceAsync_InstanceIsDeleted_ReturnsFalse
✅ ResolveCurrentInstanceAsync_MismatchingJourneyNames_ReturnsNull
✅ ResolveCurrentInstanceAsync_MismatchingStateType_ReturnsNull
✅ ResolveCurrentInstanceAsync_ReturnsSameObjectWithinSameRequest

✅ TeachingRecordSystem.WebCommon.Tests.FormFlow.JourneyInstanceTests

✅ CompleteAsync_CallsDeleteOnStateProvider
✅ DeleteAsync_CallsDeleteOnStateProvider
✅ UpdateStateAsync_CallsUpdateStateOnStateProvider
✅ UpdateStateAsync_DeletedInstance_ThrowsInvalidOperationException

✅ TeachingRecordSystem.WebCommon.Tests.FormFlow.MissingInstanceActionFilterTests

✅ RequireJourneyInstanceSpecifiedButNoActiveInstance_ReturnsNotFound
✅ RequireJourneyInstanceSpecifiedButNoMetadata_Throws
✅ RequireJourneyInstanceSpecifiedWithActiveInstance_ReturnsOk
✅ RequireJourneyInstanceSpecifiedWithOverridenStatusCodeButNoActiveInstance_ReturnsStatusCode