Fix HttpClient registration for WebhookSender #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunndabad
temporarily deployed
to
pre-production
GitHub Actions
Inactive
MrKevJoy
approved these changes
Dec 19, 2024
gunndabad
force-pushed
the
fix-httpclient-registration
branch
from
2be0629 to
dcfd21c
Compare
gunndabad
added a commit
that referenced
this pull request
Dec 30, 2024
The HttpClient configuration wasn't getting picked up as it was registered against the concrete type instead of the interface. This fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HttpClient configuration wasn't getting picked up as it was registered against the concrete type instead of the interface. This fixes that.