Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HE quals from VNext endpoints #1765

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Remove HE quals from VNext endpoints #1765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...ngRecordSystem/src/TeachingRecordSystem.Api/V3/VNext/Requests/GetPersonRequestIncludes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,11 @@ public enum GetPersonRequestIncludes
NpqQualifications = 1 << 2,
MandatoryQualifications = 1 << 3,
PendingDetailChanges = 1 << 4,
HigherEducationQualifications = 1 << 5,
Alerts = 1 << 7,
PreviousNames = 1 << 8,

[ExcludeFromSchema]
_AllowIdSignInWithProhibitions = 1 << 9,

All = Induction | InitialTeacherTraining | NpqQualifications | MandatoryQualifications | PendingDetailChanges | HigherEducationQualifications | Alerts | PreviousNames
All = Induction | InitialTeacherTraining | NpqQualifications | MandatoryQualifications | PendingDetailChanges | Alerts | PreviousNames
}
16 changes: 0 additions & 16 deletions TeachingRecordSystem/src/TeachingRecordSystem.Api/V3/VNext/Responses/GetPersonResponse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ public record GetPersonResponse
public required Option<IReadOnlyCollection<GetPersonResponseInitialTeacherTraining>> InitialTeacherTraining { get; init; }
public required Option<IReadOnlyCollection<GetPersonResponseNpqQualification>> NpqQualifications { get; init; }
public required Option<IReadOnlyCollection<GetPersonResponseMandatoryQualification>> MandatoryQualifications { get; init; }
public required Option<IReadOnlyCollection<GetPersonResponseHigherEducationQualification>> HigherEducationQualifications { get; init; }
public required Option<IReadOnlyCollection<SanctionInfo>> Sanctions { get; init; }
public required Option<IReadOnlyCollection<Alert>> Alerts { get; init; }
public required Option<IReadOnlyCollection<NameInfo>> PreviousNames { get; init; }
Expand Down Expand Up @@ -109,21 +108,6 @@ public record GetPersonResponseMandatoryQualification
public required string Specialism { get; init; }
}

[AutoMap(typeof(GetPersonResultHigherEducationQualification))]
public record GetPersonResponseHigherEducationQualification
{
public required string? Name { get; init; }
public required DateOnly? Awarded { get; init; }
public required IReadOnlyCollection<GetPersonResponseHigherEducationQualificationSubject> Subjects { get; init; }
}

[AutoMap(typeof(GetPersonResultHigherEducationQualificationSubject))]
public record GetPersonResponseHigherEducationQualificationSubject
{
public required string Code { get; init; }
public required string Name { get; init; }
}

[AutoMap(typeof(GetPersonResultInduction))]
public record GetPersonResponseInduction : InductionInfo
{
Expand Down
Loading