Set option for faster geography evaluation #7422
Draft
+81
−182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://teaching-vacancies-review-pr-7422.test.teacherservices.cloud on AKS |
scruti
force-pushed
the
set-option-for-faster-geography-evaluation
branch
from
5d0bfc8 to
d6dfb5a
Compare
By setting the "use_spheroid = false" flag in the ST_DWithin and ST_Distance PostGis over geography data, the operation benefits by a faster spherical calculation rather that the default computing on the spheroid determined by the SRID. The downside is a slightly less accurate computation. But seems a good tradeoff since we're experiencing performance issues on the distance calculations and our distances are not that big to make a huge difference on the seach results. Comment on why we repeat query for ordering Ideally we would use the 'distance' alias on the ordering, but when the location query gets combined with a 'pluck(:id)' (as it happens) call, the generated SQL query ignores the first 'select ... AS distance' bit of the query, and when 'distance' is called in the ordering, triggers an exception. For the time being, lets keep trusting the PostgreSQL query planner that doesn't recalculate the repeated distance calculation (when already done in the same query).
Remove obsolete brakeman ignored queries Ignore false SQL injection brakeman warnings
scruti
force-pushed
the
set-option-for-faster-geography-evaluation
branch
from
d6dfb5a to
5f268fc
Compare
scruti
commented
Jan 17, 2025
| @@ -1,36 +1,48 @@ | |||
| { | |||
| "ignored_warnings": [ | |||
| { | |||
| "warning_type": "Cross-Site Scripting", | |||
There was a problem hiding this comment.
As I had to add the modified SQL queries to the Brakeman ignore file, I also did an automated cleanup of legacy ignored warnings that are no longer needed. Hence all the code removal.
This is automated by brakeman -I tool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
Changes in this PR:
By setting the
use_spheroid = falseflag in theST_DWithinandST_DistancePostGis over geography data, the operation benefits from a faster spherical calculation rather than the default computing on the spheroid determined by the SRID.The downside is a slightly less accurate computation. But seems a good tradeoff since we're experiencing performance issues on the distance calculations and our distances are not that big to make a huge difference on the search results.