Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2115] Make create database optional #127

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Nov 5, 2024

Context

It is useful to let the app create the database in some cases, for instance to allow rails db:prepare to work

Changes proposed in this pull request

Make create database optional for azure DB and container DB

Guidance to review

See DFE-Digital/schools-experience#3308

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

It is useful to let the app create the database in some cases, for
instance to allow rails db:prepare to work
@saliceti saliceti added the devops label Nov 5, 2024
@saliceti
Copy link
Member Author

saliceti commented Nov 5, 2024

@saliceti saliceti merged commit b94aff3 into main Nov 5, 2024
3 checks passed
@saliceti saliceti deleted the 2115-make-create-db-optional branch November 5, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants