[2183] Allow 1 character custom domains length #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name of the custom domain in front door is the same as the subdomain. Subdomain with 1 character is allowed but not the custom domain name. Add a fix to create a longer name when the subdomain is 1 character. This is required as the length of "<domain>.<zone>" cannot exceed 64 characters and some subdomains must be 1 character to fit in.
RMcVelia
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The name of the custom domain in front door is the same as the subdomain. Subdomain with 1 character is allowed but not the custom domain name.
This is required as the length of "." cannot exceed 64 characters and some subdomains must be 1 character to fit in.
Changes proposed in this pull request
Add a fix to create a longer name when the subdomain is 1 character.
Guidance to review
Implemented in DFE-Digital/npq-registration#2070
Checklist
Devopslabel