Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widgets/text area #4995
Widgets/text area #4995
Changes from all commits
8bc9da2
55ae723
e237387
83a9a19
3ce4f1f
fa68bbe
cb549ed
ff41a5e
2ed6dcb
58c8d9b
cdda92e
a307308
b9422dc
51ff6b7
1f75f37
ff76073
6384b21
6047b40
83f9df3
4250bb4
abebac7
c005846
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to avoid polluting the public API, you can make this a local function and pass
self
to it. That is, change the function signature tolocal function textarea_onCursorChange(self, cursor, old_cursor)
and change the attribute of TextAreaContent fromon_cursor_change=self:callback('onCursorChange')
toon_cursor_change=curry(textarea_onCursorChange, self)
and then move the
textarea_onCursorChange
function above where it is referenced. This is the pattern followed in other existing wigets, such as Scrollbar and PanelSame comment for other member functions that are not part of the public API
Note this is not an issue for the
text_area/*
widgets since they are not top-levelThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this make code much harder to read and understand just to hide private API, I do not like it.
u propose a lot of local function that are in reality hided class function.
also, currying, which include another layer of understanding for a new dev.
maybe instead we should incorporate e.g. Python "private" functions by convention?
e.g.
TextArea:__onCursorChange
. This make code still quite simple to read and it will be very hard to have an accidental naming collision.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be ok with something like that. @lethosor do you have a preference?